-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix singledispatch inheritance #377
fix singledispatch inheritance #377
Conversation
erikwrede
commented
Jan 24, 2023
- fix: Make ORMField(type_) work in case there is no registered converter
- revert/feat!: Type Converters support subtypes again. this feature adjusts the conversion system to use the MRO of a supplied class
this feature adjusts the conversion system to use the MRO of a supplied class
Codecov ReportBase: 96.36% // Head: 96.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 96.36% 96.39% +0.03%
==========================================
Files 9 9
Lines 908 916 +8
==========================================
+ Hits 875 883 +8
Misses 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I removed the custom converters for BigInt and updated this class we discussed in slack/email with :
Here are the errors:
|
After following your advice on slack it loads in my app without error. |