Supplant @hybrid_property's type annotation support with Optional[T]
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 96.35% 96.38% +0.02%
==========================================
Files 9 9
Lines 714 719 +5
==========================================
+ Hits 688 693 +5
Misses 26 26
Continue to review full report at Codecov.
|
erikwrede
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supplants the previous "hybrid property type inference" work by adding support for
Optional[T]as well.Currently, all inferred hybrid properties are optional, so this work is mainly done for completeness sake (and so that we can have
Option[T]properly renderingTin GraphQL objects).An additional test was written to cover this new capability.