adding support to convert int label columns similar to PR#2

graphql-python · Sep 25, 2016 · 15b1a8d · 15b1a8d
1 parent e437058
commit 15b1a8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/graphene_sqlalchemy/converter.py b/graphene_sqlalchemy/converter.py
@@ -101,7 +101,8 @@ def convert_column_to_int_or_id(type, column, registry=None):
     if column.primary_key:
         return ID(description=column.doc, required=not(column.nullable))
     else:
-        return Int(description=column.doc, required=not(column.nullable))
+        return Int(description=getattr(column, 'doc', None),
+                  required=not(getattr(column, 'nullable', True)))
 
 
 @convert_sqlalchemy_type.register(types.Boolean)

diff --git a/graphene_sqlalchemy/tests/test_converter.py b/graphene_sqlalchemy/tests/test_converter.py
@@ -113,6 +113,11 @@ def test_should_label_convert_string():
     assert isinstance(graphene_type, graphene.String)
 
 
+def test_should_label_convert_int():
+     label = Label('int_label_test', case([], else_="foo"), type_=types.Integer())
+     graphene_type = convert_sqlalchemy_column(label)
+     assert isinstance(graphene_type, graphene.Int)
+
 def test_should_choice_convert_enum():
     TYPES = [
         (u'es', u'Spanish'),