Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions field to ExecutionResult (#188) #190

Conversation

extrin
Copy link
Contributor

@extrin extrin commented Feb 9, 2021

Add the extensions field of the ExecutionResult object for all transports.

@codecov-io
Copy link

Codecov Report

Merging #190 (1e3fff8) into master (459d5eb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          949       949           
=========================================
  Hits           949       949           
Impacted Files Coverage Δ
gql/transport/phoenix_channel_websockets.py 100.00% <ø> (ø)
gql/transport/websockets.py 100.00% <ø> (ø)
gql/transport/aiohttp.py 100.00% <100.00%> (ø)
gql/transport/requests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459d5eb...1e3fff8. Read the comment docs.

@leszekhanusz
Copy link
Collaborator

Sorry for the delay.
Could you please add some tests for this functionality?
Thanks

@codecov-commenter
Copy link

Codecov Report

Merging #190 (ee313a6) into master (459d5eb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        16    +2     
  Lines          949       978   +29     
=========================================
+ Hits           949       978   +29     
Impacted Files Coverage Δ
gql/transport/phoenix_channel_websockets.py 100.00% <ø> (ø)
gql/transport/websockets.py 100.00% <ø> (ø)
gql/transport/aiohttp.py 100.00% <100.00%> (ø)
gql/transport/requests.py 100.00% <100.00%> (ø)
gql/utils.py 100.00% <0.00%> (ø)
gql/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459d5eb...ee313a6. Read the comment docs.

@leszekhanusz leszekhanusz merged commit 24b037d into graphql-python:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants