Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aiohttp wait for closed ssl connections #153

Conversation

leszekhanusz
Copy link
Collaborator

Workaround for issue aiohttp #1925

Should fix error "RuntimeError: Event loop is closed" when using gql-cli under windows with a https backend

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #153 into master will decrease coverage by 1.45%.
The diff coverage is 56.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #153      +/-   ##
===========================================
- Coverage   100.00%   98.54%   -1.46%     
===========================================
  Files           14       14              
  Lines          927      959      +32     
===========================================
+ Hits           927      945      +18     
- Misses           0       14      +14     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 87.27% <56.25%> (-12.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f191bba...b0e2553. Read the comment docs.

@KingDarBoja KingDarBoja added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Oct 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #153 (c55d37b) into master (7f402c8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1763      1797   +34     
=========================================
+ Hits          1763      1797   +34     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f402c8...c55d37b. Read the comment docs.

@leszekhanusz leszekhanusz changed the title Fix aiohttp wait for closed connections Fix aiohttp wait for closed ssl connections Nov 26, 2021
@leszekhanusz leszekhanusz merged commit 9b85b6c into graphql-python:master Nov 26, 2021
@leszekhanusz leszekhanusz deleted the fix_aiohttp_wait_for_closed_connections branch March 12, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants