Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

ClasspathResourceSchemaStringProvider to use full constructor instead of field injection #914

Merged

Conversation

eye-dee
Copy link

@eye-dee eye-dee commented Jan 11, 2023

Hello,

I have tried to use native SB3 builds and faced NPE problem. It's related to graalvm nature of compile time boot.

The following changes helped me to solve it, please take a look
Thank you

@oliemansm
Copy link
Member

@eye-dee Thanks for your contribution!

Copy link
Member

@oliemansm oliemansm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change your commit message in line with conventional commits? See https://gist.github.com/Zekfad/f51cb06ac76e2457f11c80ed705c95a3

@eye-dee eye-dee force-pushed the feature/graalvm-issue-fix branch from 59cf3cf to f008f66 Compare January 15, 2023 08:38
@eye-dee
Copy link
Author

eye-dee commented Jan 15, 2023

Done
Please take a look

@oliemansm oliemansm merged commit 97fa815 into graphql-java-kickstart:master Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants