Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Graphiql static resource loading fix #794

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Graphiql static resource loading fix #794

merged 1 commit into from
Apr 2, 2022

Conversation

firatkucuk
Copy link

@firatkucuk firatkucuk commented Mar 22, 2022

GraphiQL screen works fine with CDN enabled option but when we try to use hosted version we need to define resources manually. voyager reactive configuration already uses automatic static resource loading.

@ConditionalOnProperty(value = "graphql.graphiql.cdn.enabled", havingValue = "false")

did not work properly, that's why I put a if condition there.

@BlasiusSecundus
Copy link

Thanks for the contribution, could you please squash it into one commit, and use conventional commit message (e.g. fix(#793): graphiql static resource loading)?

Additional suggestion: use @ConditionalOnProperty instead of the Boolean parameter.

@firatkucuk
Copy link
Author

firatkucuk commented Mar 22, 2022

I've tested via unit tests both cdn enabled and disabled case. But resources are always visible under static folder for unit and integration tests. Because static is a special folder. So I've tested it via temporarily renaming the static folder. IMHO resources should be in a different directory like resources or assets.

@firatkucuk firatkucuk changed the title Graphiql static resource loading #793 Graphiql static resource loading fix Mar 22, 2022
@oliemansm oliemansm added this to the 13.0.0 milestone Apr 2, 2022
@oliemansm oliemansm linked an issue Apr 2, 2022 that may be closed by this pull request
@oliemansm oliemansm merged commit bf3daea into graphql-java-kickstart:master Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphiQL Configuration doesn't contain static resource loader
3 participants