This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
fix(#524): return valid error even if request body is invalid #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlasiusSecundus You're not actually returning a 500 status code but it stays a 200 OK reponse code right? Seeing the code and also your comment on the linked issue. It's just that the subject of this PR communicates something else, so wanted to double check. |
|
Yes, the commit message is misleading. The bug was the 500 error, not the fix. I will correct that. |
…ody is invalid A valid GraphQL error response is returned with a descriptive error message instead of HTTP 500 with internal details. Details of the parse error is logged server-side.
BlasiusSecundus
force-pushed
the
feature/fix-invalid-json-handling
branch
from
8a94165 to
740491f
Compare
BlasiusSecundus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A valid GraphQL error response is returned instead with a descriptive error message. Details of the parse error is logged server-side.