Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Weird characters on Playground since last release #495

Closed
ooga opened this issue Dec 22, 2020 · 5 comments · Fixed by #507
Closed

Weird characters on Playground since last release #495

ooga opened this issue Dec 22, 2020 · 5 comments · Fixed by #507
Labels
Milestone

Comments

@ooga
Copy link

ooga commented Dec 22, 2020

Describe the bug
Weird characters on Playground since release 8.1.0, looks like a charset issue.
Everything is working fine with version 8.0.0

image

To Reproduce
Steps to reproduce the behavior:

  1. Use com.graphql-java-kickstart:playground-spring-boot-starter:8.1.0
@ooga ooga added the bug label Dec 22, 2020
@oliemansm
Copy link
Member

Playground has been upgraded to 1.7.26 in release 8.1.0. Could you try with an earlier version of playground by enabling CDN to see if that "solves" the problem? That way we'll know if it's something in that release of Playground or if it's something else.

graphql.playground:
    cdn:
        enabled: true
        version: "1.7.20"

@ooga
Copy link
Author

ooga commented Dec 22, 2020

Enabling cdn solves the problem 👍
It even works well with version: "1.7.26"

@oliemansm
Copy link
Member

Ok, so it has something to do with the static version hosted along with the code, but not with this specific Playground version. That helps in finding the cause. Thanks for confirming 👍🏻

BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Dec 30, 2020
@BlasiusSecundus
Copy link

BlasiusSecundus commented Dec 30, 2020

I could not reproduce, but I ran into the same issue while working on Playground for WebFlux (#487), strangely only affecting the webflux version.

For that, the simple fix in this commit did the trick. @ooga , could you please try?

(Update: with the webflux version, I could also reproduce the phenomenon that it works if the files are loaded from CDN.)

@ooga
Copy link
Author

ooga commented Jan 4, 2021

I confirm the commit fix the issue 👍

oliemansm added a commit that referenced this issue Jan 4, 2021
…ncoding

fix(#495): character encoding issue with Playground
@oliemansm oliemansm added this to the 11.0.0 milestone Jan 4, 2021
@oliemansm oliemansm linked a pull request Jan 4, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants