fix: Memory leak when using reactive subscriptions with KeepAlive

graphql-java-kickstart · May 26, 2021 · 088b32c · 088b32c
1 parent 897c477
commit 088b32c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/.../src/main/java/graphql/kickstart/spring/webflux/ReactiveWebSocketSubscriptionSession.java b/.../src/main/java/graphql/kickstart/spring/webflux/ReactiveWebSocketSubscriptionSession.java
@@ -8,6 +8,7 @@
 public class ReactiveWebSocketSubscriptionSession extends DefaultSubscriptionSession {
 
   private final WebSocketSession webSocketSession;
+  private boolean opened = true;
 
   public ReactiveWebSocketSubscriptionSession(
       GraphQLSubscriptionMapper mapper, WebSocketSession webSocketSession) {
@@ -17,7 +18,7 @@ public ReactiveWebSocketSubscriptionSession(
 
   @Override
   public boolean isOpen() {
-    return true;
+    return opened;
   }
 
   @Override
@@ -34,4 +35,10 @@ public String getId() {
   public WebSocketSession unwrap() {
     return webSocketSession;
   }
+
+  @Override
+  public void close(final String reason) {
+    super.close(reason);
+    this.opened = false;
+  }
 }