Provider for creating missing resolver data fetcher to provide options and field definition to factory #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and field definition to factory
oryan-block
approved these changes
Apr 28, 2023
src/main/kotlin/graphql/kickstart/tools/resolver/MissingFieldResolver.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/graphql/kickstart/tools/resolver/MissingResolverDataFetcherProvider.kt
Outdated
Show resolved
Hide resolved
|
Thanks @oryan-block for the review. Applied your suggestions. Let me know if there is anything else! |
oryan-block
reviewed
May 1, 2023
oryan-block
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider for creating missing resolver data fetcher to provide options and field definition to factory
Resolves #741
Checklist
Description
Allow missing field resolver data fetcher usage a hook to the field definition and options. Moves away from provide a concrete data fetcher implementation and provide a functional interface (aka Provider) when creating the missing resolver data fetchers and pass the field definition and schema parser options for context.