Remove bintray and deploy to maven central #521
Conversation
| server-id: ossrh | ||
| server-username: MAVEN_USERNAME | ||
| server-password: MAVEN_PASSWORD | ||
| gpg-private-key: ${{ secrets.GPG_KEY_CONTENTS }} |
There was a problem hiding this comment.
This is a bit of a guess but I assume we want the actual key here and not the key id or something else.
There was a problem hiding this comment.
That variable is actually the file but base64 encoded. So it's the password encoded file that contains the key. See also the document I wrote in which I tried to explain that.
There was a problem hiding this comment.
Once you've made the changes you could run the action to try to publish the snapshot to the repo to prove it works. In these kind of cases that's the only way I know to really verify it works as intended.
I did the same thing for publishing an actual release to the staging repo but with close and release disabled. That way I could prove it was signing it correctly with gpg and uploading to nexus correctly. I then deleted those uploads manually afterwards, but at least I proved to myself the config was correct.
I'd advise a similar approach here.
pom.xml
Outdated
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://s01.oss.sonatype.org/</nexusUrl> |
There was a problem hiding this comment.
Our repo was created in the original one, so you should be using the same repository url as the one used in gradle.
There was a problem hiding this comment.
That would be oss.sonatype.org, right?
| server-id: ossrh | ||
| server-username: MAVEN_USERNAME | ||
| server-password: MAVEN_PASSWORD | ||
| gpg-private-key: ${{ secrets.GPG_KEY_CONTENTS }} |
There was a problem hiding this comment.
That variable is actually the file but base64 encoded. So it's the password encoded file that contains the key. See also the document I wrote in which I tried to explain that.
pom.xml
Outdated
| <name>graphql-java-kickstart-graphql-java-tools</name> | ||
| <url>http://oss.jfrog.org/artifactory/oss-snapshot-local</url> | ||
| <id>ossrh</id> | ||
| <url>https://s01.oss.sonatype.org/content/repositories/snapshots</url> |
There was a problem hiding this comment.
This url should be corrected too.
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> |
There was a problem hiding this comment.
Shouldn't this be: https://oss.sonatype.org/service/local/staging/deploy/maven2?
There was a problem hiding this comment.
according to the guide it should be enough:
https://central.sonatype.org/publish/publish-maven/#distribution-management-and-authentication
Checklist
Description
Following the closure of bintray we need to replace it with direct deployment to maven central.
Unfortunately, following the rest of the org's gradle based config doesn't seem possible.
However, according to this guide and the documentation here this should work.