Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error when DataFetcherResult is not the root type #488

Merged

Conversation

ooga
Copy link
Contributor

@ooga ooga commented Mar 9, 2021

Resolves https://spectrum.chat/graphql-java-kick/tools/list-of-datafetcherresults~9ca373af-c480-4ae5-869a-775ca8f1885e

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

graphql-java supports lists of DataFetcherResult.

This PR remove error when DataFetcherResult is not the root return type

@ooga
Copy link
Contributor Author

ooga commented Mar 26, 2021

@vojtapol Any time soon to check/validate this ?

Copy link
Collaborator

@oryan-block oryan-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vojtapol vojtapol merged commit 4838538 into graphql-java-kickstart:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants