-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to allow unused types #445
feat: Add option to allow unused types #445
Conversation
Hi @vojtapol. Can you take a look at this approach? Is it valid? What do you think? Looking forward to getting your feedback. |
This looks like a straightforward way to expose the schema as written and unblock the ability to extend a type in the federation use case. Looking forward to seeing this get a maintainer review. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the contribution. It has no impact on existing users whatsoever which is great.
Thank you @vojtapol for merging the PR! What is the release process? When should we expect a new version with the changes to be released? |
THis might save others some time
Apologies if its reads obvious to others, however it took me a while to set up a working example (danilo's test case was extremely helpful!) so i wanted to share it here. |
Resolves #442
Resolves #420
Checklist
Description
Adding a new
includeUnusedTypes
option to include unused types to the final executable schema. The caveat is that the unused types need to be included in the schema parser dictionary. I think it is an ok tradeoff as this feature has specific use cases as described in #420 and #442.Added a couple of test cases to it as well as serve as both test and example of how to use it.