Potential fix for #407 #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raphql-java-kickstart#407 # Conflicts: # src/main/kotlin/graphql/kickstart/tools/SchemaParser.kt # src/test/groovy/graphql/kickstart/tools/FieldResolverScannerSpec.groovy
|
Thanks for the contribution. I am looking into it. |
|
Thank you for investigating this. I have used this PR as an inspiration for the fix here: |
|
Perfect. That looks better. Thanks for having a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially Fixes #407
Checklist
Description
This aims to to fix #407 . The problem appears to be caused by the resolver choosing a interface method as the resolver for a field, without checking if there are other resolvers for the same field with a more concrete return type. There are multiple possible issues still left to be adressed i believe: