fix no-unreachable-types ignore types from directive arguments with…

… request locations (#1469)
graphql-hive · Feb 26, 2023 · 6b4e20c · 6b4e20c
1 parent 5779329
commit 6b4e20c
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/.changeset/honest-yaks-trade.md b/.changeset/honest-yaks-trade.md
@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+fix `no-unreachable-types` ignore types from directive arguments with request locations
diff --git a/packages/plugin/src/rules/no-unreachable-types.ts b/packages/plugin/src/rules/no-unreachable-types.ts
@@ -98,6 +98,12 @@ function getReachableTypes(schema: GraphQLSchema): ReachableTypes {
   for (const node of schema.getDirectives()) {
     if (node.locations.some(location => RequestDirectiveLocations.has(location))) {
       reachableTypes.add(node.name);
+      for (const arg of node.args) {
+        const argTypeName = 'name' in arg.type && arg.type.name;
+        if (argTypeName) {
+          reachableTypes.add(argTypeName);
+        }
+      }
     }
   }
 

diff --git a/packages/plugin/tests/no-unreachable-types.spec.ts b/packages/plugin/tests/no-unreachable-types.spec.ts
@@ -148,6 +148,17 @@ ruleTester.runGraphQLTests('no-unreachable-types', rule, {
         type Query
       `),
     },
+    {
+      name: 'should ignore types from directive arguments with request locations',
+      ...useSchema(/* GraphQL */ `
+        enum Enum {
+          A
+          B
+        }
+        directive @q(arg: Enum = A) on QUERY
+        type Query
+      `),
+    },
   ],
   invalid: [
     {