-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Hive Gateway Next.js example #6481
Conversation
📝 WalkthroughSummary by CodeRabbit
Summary by CodeRabbit
WalkthroughThe documentation for Hive Gateway integration with Next.js has been updated. The initial description has been retained but expanded to include a reference to a custom route handler. The example section has been significantly altered, replacing previous comments with a directive to consult the relevant documentation. Additionally, a new import statement for Changes
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/web/docs/src/content/gateway/deployment/node-frameworks/nextjs.mdx (2)
17-17
: Improve Link Formatting for Clarity
The directive now clearly instructs users to review the Next.js router handlers documentation. For enhanced usability and to ensure the link is clickable when copy-pasting, consider formatting it as a proper Markdown link, for example:Please read the [Next.js Router Handlers documentation](https://nextjs.org/docs/app/building-your-application/routing/router-handlers) first.
19-29
: Enhance Code Snippet Completeness
The updated code snippet now includes the import forsupergraph
, which makes the example more self-contained and copy-pasteable. Ensure that the referenced file (./my-supergraph
) is either included in the repository or clearly marked as a placeholder in the documentation. This will help prevent confusion for developers who might otherwise look for an actual implementation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/web/docs/src/content/gateway/deployment/node-frameworks/nextjs.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`packages/web/docs/**`: The main landing page and documentat...
packages/web/docs/**
: The main landing page and documentation website. It's built using TypeScript, Tailwind, NextJS and Nextra.In PRs that adds a new feature to the product, we would like to make sure that the PR includes the following:
- Up to date documentation in
packages/web/docs/src/content
- A product update in
packages/web/docs/src/app/product-updates
packages/web/docs/src/content/gateway/deployment/node-frameworks/nextjs.mdx
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: alpha / cli-artifacts
- GitHub Check: test / unit
- GitHub Check: static-analysis / analyze (typescript)
- GitHub Check: typescript / typecheck
- GitHub Check: code-style / eslint-and-prettier
- GitHub Check: static-analysis / analyze (javascript)
- GitHub Check: build / dockerize (linux/arm64)
- GitHub Check: validate-mdx-links / validate-mdx-links
- GitHub Check: build / dockerize (linux/amd64)
Fixes #6453
Examples should be copy-pasteable and not include changes that don't work or lack context.