New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Preserve Extensions in FormattedError during concurrent execution #706

Open

maakun12 wants to merge 1 commit into graphql-go:master from maakun12:concurrent-error-extensions

+3 −0

maakun12 commented Dec 5, 2024

When resolving fields concurrently, error extensions are lost in the error handling chain.
This happens because:

The error is converted to FormattedError in completeThunkValueCatchingError through panic/recover flow
In newLocatedError, the OriginalError is set to a new *gqlerrors.Error created from the FormattedError
During FormatError, the extensions from the FormattedError are lost


          fix: Preserve Extensions in FormattedError during concurrent execution

fcbd19e

coveralls commented Dec 5, 2024

coverage: 92.048%. remained the same
when pulling fcbd19e on maakun12:concurrent-error-extensions
into a546af7 on graphql-go:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet