Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #34

Closed
wants to merge 9 commits into from
Closed

Update README.md #34

wants to merge 9 commits into from

Conversation

pyrossh
Copy link
Contributor

@pyrossh pyrossh commented Oct 29, 2015

Add some stuff discussed in issues

@EmergentBehavior
Copy link
Contributor

I already have an existing PR for a lot of this, see: https://github.com/chris-ramon/graphql-go/pull/32.

@pyrossh
Copy link
Contributor Author

pyrossh commented Oct 29, 2015

Yeah I Know... But It was too late I had already done the work .. So I merged yours into mine. Plus I have an example. Anyway's lets see what happens...

@sogko
Copy link
Member

sogko commented Oct 29, 2015

Hi guys

I think it's fine to have 2 separate PRs, we'll merge in #32 first, followed by #34. That will give proper contribution credits for all involved 👍🏻

I want to give @chris-ramon a chance to review #32 first before merging it, from there we'll move on to this.

Thanks again guys!

@EmergentBehavior
Copy link
Contributor

Cool beans -- the important part is we're ramping up contributions for the lib :)

@chris-ramon
Copy link
Member

Thanks a lot @pyros2097!

I went ahead and merged #38 which contains similar updates if this PR, so could we just preserve from this PR the following two sections:

  • Other Libraries Related
  • Blog Posts that might be useful

Might I suggest for Other Libraries Related rename to Third Party Libraries and have a table like this so we could have some like the following:

Third Party Libraries

Here is a current list of graphql compatible libraries. Feel free to put up a PR to add missing ones:

Name Author Description
graphql-go-handler Hafiz Ismail Middleware to handle GraphQL queries through HTTP requests.

For Blog Posts that might be useful rename to Blog Posts:

Blog Posts

For Example section I think we can handle in a new PR, since API had changed and not yet merge #20, and it should perhaps be very similar to the one on graphql-js - Using GraphQL.js section.

Please do share your thoughts on this, thanks! 👍

@pyrossh
Copy link
Contributor Author

pyrossh commented Nov 3, 2015

Hi @chris-ramon,

I Think it all good since the API is changed. I'll just make another pull request for the other sections so that its even with your master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants