-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #34
Update README.md #34
Conversation
I already have an existing PR for a lot of this, see: https://github.com/chris-ramon/graphql-go/pull/32. |
Yeah I Know... But It was too late I had already done the work .. So I merged yours into mine. Plus I have an example. Anyway's lets see what happens... |
Hi guys I think it's fine to have 2 separate PRs, we'll merge in #32 first, followed by #34. That will give proper contribution credits for all involved 👍🏻 I want to give @chris-ramon a chance to review #32 first before merging it, from there we'll move on to this. Thanks again guys! |
Cool beans -- the important part is we're ramping up contributions for the lib :) |
Thanks a lot @pyros2097! I went ahead and merged #38 which contains similar updates if this PR, so could we just preserve from this PR the following two sections:
Might I suggest for Third Party LibrariesHere is a current list of graphql compatible libraries. Feel free to put up a PR to add missing ones:
For Blog PostsFor Please do share your thoughts on this, thanks! 👍 |
Hi @chris-ramon, I Think it all good since the API is changed. I'll just make another pull request for the other sections so that its even with your master. |
Add some stuff discussed in issues