Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds schema parser tests. #11

Closed
wants to merge 2 commits into from
Closed

Adds schema parser tests. #11

wants to merge 2 commits into from

Conversation

chris-ramon
Copy link
Member

  • Fixes parser.parseType typo.
  • Adds schema parser tests ported from schema_parser_test.js.

@sogko
Copy link
Member

sogko commented Sep 24, 2015

👍🏻

Just a heads up, schema_parser_test.go was added in in PR #10 as well, along with parser fix.
Once you merge this into master, I can merge the possible conflict for you (most probably I'll just replace schema_parser_test.go with this version.

@chris-ramon
Copy link
Member Author

@sogko let's merge yours.

@chris-ramon chris-ramon deleted the schema_parser_tests branch September 25, 2015 22:57
lenaten pushed a commit to lenaten/graphql-go that referenced this pull request Nov 2, 2015
@sogko
Merge pull request graphql-go#11 from chris-ramon/master
50a77ca 
Merge latest changes from HEAD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-ramon @sogko