Append newline to printed documents #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Aug 18, 2024
| return VisitAsync(node, context); | ||
| await VisitAsync(node, context).ConfigureAwait(false); | ||
| if (!context.NewLinePrinted && node is GraphQLDocument) | ||
| await writer.WriteLineAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
Changes were made only within PrintAsync and only for printed documents, not for individual nodes being printed, or where VisitAsync was called directly and the context could be examined to determine whether or not a newline had been printed.
Shane32
commented
Aug 18, 2024
Comment on lines
140
to
142
|
|
||
| extend type Foo @onType No newline at end of file | ||
| extend type Foo @onType |
There was a problem hiding this comment.
This PR fixes these issues -- generated documents did not include a terminating newline before.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 96.12% 96.10% -0.02%
==========================================
Files 89 89
Lines 5030 5032 +2
Branches 500 500
==========================================
+ Hits 4835 4836 +1
Misses 194 194
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
gao-artur
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like this merged in for v9.4.0 in preparation for GraphQL.NET v8.0. Note: GraphQL.NET v7.x uses the v8 parser.