Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init-only setters for full .NET Standard / .NET Framework compatibility #319

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Apr 26, 2023

Target Parser 10.x ??

@Shane32 Shane32 requested a review from sungam3r April 26, 2023 14:10
@Shane32 Shane32 self-assigned this Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #319 (9f27cd5) into master (f11f0d2) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          85       85           
  Lines        4892     4892           
  Branches      477      477           
=======================================
  Hits         4708     4708           
  Misses        184      184           
Impacted Files Coverage Δ
src/GraphQLParser/Visitors/CountVisitor.cs 100.00% <100.00%> (ø)
src/GraphQLParser/Visitors/MaxDepthVisitor.cs 100.00% <100.00%> (ø)
src/GraphQLParser/Visitors/SDLPrinter.cs 99.74% <100.00%> (ø)
src/GraphQLParser/Visitors/StructurePrinter.cs 100.00% <100.00%> (ø)

@sungam3r
Copy link
Member

I would not. Moreover, I would not treat init with such caution. We have not yet written a single issue about problems with init. Nevertheless, I'm OK to merge this one as is.

@Shane32 Shane32 merged commit 21e0940 into master Apr 26, 2023
@Shane32 Shane32 deleted the remove_initonly branch April 26, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants