Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PublicApiGenerator from 10.3.0 to 11.0.0 #291

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Bump PublicApiGenerator from 10.3.0 to 11.0.0 #291

merged 1 commit into from
Mar 7, 2023

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Mar 7, 2023

No description provided.

@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Mar 7, 2023
@sungam3r sungam3r added the dependencies Pull requests that update a dependency file label Mar 7, 2023
@Shane32
Copy link
Member

Shane32 commented Mar 7, 2023

This reveals that we have obvious flaws in our public API surface, as we have init; properties with no other way to set the property.

@sungam3r
Copy link
Member Author

sungam3r commented Mar 7, 2023

init; properties with no other way to set the property.

But... this is the purpose of init.

@Shane32
Copy link
Member

Shane32 commented Mar 7, 2023

init; is not compatible with certain runtimes, namely, .NET Framework. A constructor is necessary if we want to maintain compatibility with .NET Framework.

@codecov-commenter
Copy link

Codecov Report

Merging #291 (c052bbf) into master (7843ce3) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         4522      4522           
  Branches       454       454           
=========================================
  Hits          4522      4522           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32
Copy link
Member

Shane32 commented Mar 7, 2023

@sungam3r
Copy link
Member Author

sungam3r commented Mar 7, 2023

I undestand. Your words sounded like init is a flaw itself.

@sungam3r
Copy link
Member Author

sungam3r commented Mar 7, 2023

I remember that issue with ValidationOptions.

@sungam3r sungam3r merged commit e1bcd02 into master Mar 7, 2023
@sungam3r sungam3r deleted the api branch March 7, 2023 15:46
@sungam3r
Copy link
Member Author

sungam3r commented Mar 7, 2023

if we want to maintain compatibility with .NET Framework.

Yep but nobody complained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file test Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants