-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for variable coercion #1919
Conversation
At first glance, it seems strange why one request works, and the second does not. This question came up on one of our development teams. |
Well, in fact, everything is a little more interesting. See graphql/graphql-js#1324 |
If you want, then I can merge this test for 3.1 and then in 3.2 we will "fix" it. We can also defer this PR to 3.2 and make corrections right here. |
I’d probably at least add a todo note that this is unintended or incorrect behavior. The way I’m planning to fix this will probably be breaking and need to be in 4.0. I can explain later. Maybe a patch could be implemented for 3.2. Good to have this test though. |
@sungam3r I suggest we merge this test. It may be useful when I start reworking the input code. |
Small test to verify behavior for variable coercion and error for wrong literal.