Graphql 5.3 #232
Graphql 5.3 #232
Conversation
|
This would also help resolve the NewtonsoftJson vulnerability for versions < 13.0.1 Currently this package references |
|
I advise to switch to STJ whenever possible. |
| public override object Resolve(IResolveFieldContext context) | ||
| { | ||
| return context.Source; | ||
| } |
There was a problem hiding this comment.
This is critical for subscription support.
There was a problem hiding this comment.
Thanks a lot @Shane32
src/GraphQL.Conventions/Adapters/Resolvers/EventStreamResolver.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane Krueger <[email protected]>
|
|
||
| // ReSharper disable InconsistentNaming | ||
|
|
||
| namespace Tests.Adapters.Engine.Types | ||
| { | ||
| #region .NET Class | ||
| public class JSON : ValueNode<IDictionary<string, object>> | ||
| public class JSON : GraphQLValue |
There was a problem hiding this comment.
FYI this test is completely wrong (not the fault of this PR). Deserializing a GraphQL request cannot possibly deserialize to a JSON node. Rather, ParseLiteral should be parsing a structured tree of objects and values into an Inputs object or something, or interpreting a JSON string value stored as a string literal and deserializing it as an Inputs object. Further, the ParseValue method should probably just take the object and return it, as the GraphQL serializer should be deserializing variables into a structured map. It won't ever be a GraphQLValue node of any kind. And ToAST should convert the structured map into a tree of nodes.
|
LGTM – will let @sungam3r take a look as well |
Upgrading to Graph QL 5.3 to use with the last version of Graph QL Server and dotnet 6.
I still have an issue in the Graph QL Subscription Sample Project if someone can help me have a look.
I couldn't find the issue (it runs but there is an exception on runtime when you update a field and have a subscription), I would need to dig dipper in Graph QL dotnet internals and all the reflection but I didn't have time.
Other things seems to work