Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detect ethereum-network #554

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Auto-detect ethereum-network #554

merged 7 commits into from
Dec 9, 2022

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Dec 7, 2022 •
edited
Loading

  • Rely on chainID from ethereum provider instead of argv.ethereumNetwork.
  • Remove --ethereum-network from indexer-agent.

@tilacog tilacog self-assigned this Dec 7, 2022
@tilacog tilacog force-pushed the tiago/oracle-robustness branch from af9bd9b to 22ce0b9 Compare December 8, 2022 16:44
@tilacog tilacog changed the title Epoch Block Oracle Robustness Auto-detect ethereum-network Dec 8, 2022
@tilacog tilacog marked this pull request as ready for review December 8, 2022 18:02
@tilacog tilacog requested a review from fordN December 8, 2022 18:02
fordN
fordN approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/indexer-common/CHANGELOG.md Outdated Show resolved Hide resolved
packages/indexer-common/src/indexer-management/types.ts Outdated Show resolved Hide resolved
@tilacog
Copy link
Contributor Author

tilacog commented Dec 9, 2022 •
edited
Loading

I'll squash some commits before merging

@tilacog tilacog force-pushed the tiago/oracle-robustness branch from fddf2e4 to 445530c Compare December 9, 2022 20:18
@tilacog tilacog merged commit 730d3dd into main Dec 9, 2022
@tilacog tilacog deleted the tiago/oracle-robustness branch December 9, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordN fordN fordN approved these changes

Assignees

@tilacog tilacog

Labels
enhancement New feature or request indexer-agent indexer-common
Projects
Indexer
Status: 🚗 Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilacog @fordN