Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: indexer-common schema allow null node #550

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 2, 2022

Indexer common schema specification updated to be less strict - allow node to be null to account for unassigned deployments
resolve #546

Updated behavior example

Indexer Deployments
┌────────────────────────────────────────────────┬────────┬─────────┬────────────┬─────────┬─────────┬───────────────────┬──────────────────────┬─────────────────────┐
│ deployment                                     │ synced │ health  │ fatalError │ node    │ network │ latestBlockNumber │ chainHeadBlockNumber │ earliestBlockNumber │
├────────────────────────────────────────────────┼────────┼─────────┼────────────┼─────────┼─────────┼───────────────────┼──────────────────────┼─────────────────────┤
│ Qmdsp5yyFzMVUdSv5N9KndTisjXHrGDEXNaBxjyCTvDfPs │ true   │ healthy │ -          │ null    │ goerli  │ 8061655           │ 8061655              │ 7664657             │
├────────────────────────────────────────────────┼────────┼─────────┼────────────┼─────────┼─────────┼───────────────────┼──────────────────────┼─────────────────────┤
│ QmaCRFCJX3f1LACgqZFecDphpxrqMyJw1r2DCBHXmQRYY8 │ true   │ healthy │ -          │ default │ goerli  │ 8061655           │ 8061655              │ 7812428             │
└────────────────────────────────────────────────┴────────┴─────────┴────────────┴─────────┴─────────┴───────────────────┴──────────────────────┴─────────────────────┘

@hopeyen hopeyen changed the title Fix: indexer-common schema allow null node for indexer deployment Fix: indexer-common schema allow null node Dec 2, 2022
@hopeyen hopeyen force-pushed the hope/indexer-deployment-null-node branch from 34f8547 to c823661 Compare December 2, 2022 17:18
@hopeyen hopeyen requested a review from fordN December 2, 2022 17:42
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hopeyen hopeyen merged commit a90fceb into main Dec 5, 2022
@hopeyen hopeyen deleted the hope/indexer-deployment-null-node branch December 5, 2022 20:42
@fordN fordN added bug Something isn't working indexer-common labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working indexer-common
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

Cannot return null for non-nullable field IndexerDeployment.node.
2 participants