indexer-common: Support connecting to any protocol network #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If ethereumNetwork name not provided fallback to 'any', to support non-standard networks with unknown names like arbitrum-goerli, etc... - Move network provider connection establishment to a shared indexer-common function for usage by indexer-agent and indexer-service
fordN
force-pushed
the
ford/network-provider-support-all-chains
branch
from
d6ad978 to
b23bf62
Compare
hopeyen
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support connecting to providers for any network I am updating the handling of the ethereum-network argument on startup. If ethereumNetwork name not provided the provider will use network = 'any'. This change effectively adds support for non-standard networks with unknown names like arbitrum-goerli, etc.... The user may still specify a network name if they know it: i.e "mainnet" which provides an extra check that the provider is connecting to the correct network.
While in there I also moved the code to connect to the network provider to a shared indexer-common function for usage by both indexer-agent and indexer-service.