Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-agent,-common: Use consistent clear network/epoch var naming #511

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Oct 17, 2022

Main changes:

  • Update network identifier and epoch variable names to improve clarity and consistency as we move to a more complex multi-chain world.
  • Use the user provided network name rather than the JSON-RPC provider returned network name when resolving POIs.

I also included some more general code organization improvements.

  • Moved type definitions that have been accumulating in the allocations module in indexer-common to a more general types file.
  • Remove redundant variables in a few places.
  • Include components name in logger passed into ActionManager and AllocationManager.

@fordN fordN requested a review from hopeyen October 17, 2022 16:41
@fordN fordN force-pushed the ford/update-network-id-and-epoch-naming branch 2 times, most recently from d674d80 to 20ce8da Compare October 17, 2022 16:57
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I think there's just a small change needed

packages/indexer-common/src/indexer-management/monitor.ts Outdated Show resolved Hide resolved
@fordN fordN force-pushed the ford/update-network-id-and-epoch-naming branch from 20ce8da to 42f4ee3 Compare October 17, 2022 17:42
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@fordN fordN merged commit 76922a3 into main Oct 17, 2022
@fordN fordN deleted the ford/update-network-id-and-epoch-naming branch October 17, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants