Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-common: Trace log data used to evaluate each deployment #505

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Oct 11, 2022

It's currently a bit tricky to debug allocation decisions. To improve debug process this PR adds an additional trace log at the beginning of isDeploymentWorthAllocatingTowards() which includes the deployment's data and the matching rule it is being evaluated against.

- Useful to trace why the agent decided to allocate on a deployment
@fordN fordN force-pushed the ford/log-deployment-evaluation-data branch from 6b97cbe to cc680b9 Compare October 11, 2022 18:47
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fordN fordN merged commit 9e54fb1 into main Oct 11, 2022
@fordN fordN deleted the ford/log-deployment-evaluation-data branch October 11, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants