common, agent: switch most timer calls to sequential impl #1065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new functions which implement a sequential timer with back-pressure, as well as using those in place of where we previously used a
timer(...).tryMap|pipe|map|reduce
.A long standing issue with
timer()
is that it's blind to the work done further down the combinator pipeline. So if the work in a timer took longer than the nextsetInterval
backing the timer to complete, we could potentially start executing the next iteration before completing the one we are currently on.These newly introduced functions watch the amount of work done in their
Mapper
orReducer
functions respectively.I'm considering this a stop-gap solution as it provides a single logged function which still makes use of eventuals.