indexer-common: Validate cost models in setCostModel

I tried baking this right into the sequelize model so that we
could be certain a model is valid before it hits the db, but
I always got errors that `CostModel` was not set on `undefined`,
so something with the `addon` inside the cost model library wasn't
right. Either way, this does what we want it to do.

packages/indexer-common/src/indexer-management/__tests__/cost-models.ts

@@ -16,6 +16,8 @@ import {
   IndexerManagementFeatures,
 } from '../client'
 import { defineIndexerManagementModels, IndexerManagementModels } from '../models'
+import { CombinedError } from '@urql/core'
+import { GraphQLError } from 'graphql'
 
 // Make global Jest variable available
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -580,3 +582,69 @@ describe('Feature: Inject $DAI variable', () => {
     ).resolves.toHaveProperty('data.costModels', [update])
   })
 })
+
+describe('Cost model validation', () => {
+  test('Invalid cost models are rejected', async () => {
+    const client = await createIndexerManagementClient({
+      models,
+      address,
+      contracts,
+      logger,
+      defaults,
+      features: {
+        injectDai: false,
+      },
+    })
+
+    const costModel = {
+      deployment: '0x0000000000000000000000000000000000000000000000000000000000000000',
+      model: 'default => 1.0', // semicolon missing
+      variables: '{}',
+    }
+
+    await expect(
+      client.mutation(SET_COST_MODEL_MUTATION, { costModel }).toPromise(),
+    ).resolves.toHaveProperty(
+      'error',
+      new CombinedError({
+        graphQLErrors: [
+          new GraphQLError(
+            'Invalid cost model or variables: Failed to compile cost model',
+          ),
+        ],
+      }),
+    )
+  })
+
+  test('Invalid cost model variables are rejected', async () => {
+    const client = await createIndexerManagementClient({
+      models,
+      address,
+      contracts,
+      logger,
+      defaults,
+      features: {
+        injectDai: false,
+      },
+    })
+
+    const costModel = {
+      deployment: '0x0000000000000000000000000000000000000000000000000000000000000000',
+      model: 'default => 1.0;',
+      variables: '"foo"',
+    }
+
+    await expect(
+      client.mutation(SET_COST_MODEL_MUTATION, { costModel }).toPromise(),
+    ).resolves.toHaveProperty(
+      'error',
+      new CombinedError({
+        graphQLErrors: [
+          new GraphQLError(
+            'Invalid cost model or variables: Failed to compile cost model',
+          ),
+        ],
+      }),
+    )
+  })
+})

packages/indexer-common/src/indexer-management/resolvers/cost-models.ts

@@ -3,6 +3,7 @@
 
 import { CostModelVariables, GraphQLCostModel, parseGraphQLCostModel } from '../models'
 import { IndexerManagementResolverContext } from '../client'
+import { compileAsync } from '@graphprotocol/cost-model'
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const getVariable = (vars: CostModelVariables | null, name: string): any | undefined => {
@@ -68,6 +69,15 @@ export default {
   ): Promise<object> => {
     const update = parseGraphQLCostModel(costModel)
 
+    // Validate cost model
+    try {
+      const modelForValidation = update.model || 'default => 1;'
+      const variablesForValidation = JSON.stringify(update.variables || {})
+      await compileAsync(modelForValidation, variablesForValidation)
+    } catch (err) {
+      throw new Error(`Invalid cost model or variables: ${err.message}`)
+    }
+
     const [model] = await models.CostModel.findOrBuild({
       where: { deployment: update.deployment },
     })