Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subgraph health endpoint #449

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

shiyasmohd
Copy link
Contributor

This PR is the second part of #408

@coveralls
Copy link

coveralls commented Nov 3, 2024

Pull Request Test Coverage Report for Build 11730200896

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 54 (0.0%) changed or added relevant lines in 2 files are covered.
  • 135 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.1%) to 72.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 7 0.0%
common/src/indexer_service/http/health.rs 0 47 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.23%
common/src/tap.rs 5 0.0%
tap-agent/src/cli.rs 5 0.0%
common/src/tap/checks/value_check.rs 14 90.7%
config/src/config.rs 19 91.21%
common/src/indexer_service/http/request_handler.rs 26 0.0%
service/src/service.rs 65 0.0%
Totals Coverage Status
Change from base Build 11671559646: -2.1%
Covered Lines: 5673
Relevant Lines: 7823

💛 - Coveralls

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the code. These are some concerns regarding health rate limit and using a different tool for graphql queries.

common/src/indexer_service/http/indexer_service.rs Outdated Show resolved Hide resolved
common/src/indexer_service/http/health.rs Outdated Show resolved Hide resolved
@shiyasmohd
Copy link
Contributor Author

@gusinacio Thanks for the review. Pushed the changes.

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some syntax improvement and we are good to merge

common/src/indexer_service/http/health.rs Outdated Show resolved Hide resolved
common/src/indexer_service/http/health.rs Outdated Show resolved Hide resolved
common/src/indexer_service/http/health.rs Outdated Show resolved Hide resolved
@shiyasmohd
Copy link
Contributor Author

@gusinacio Thanks for the suggestions. Pushed the changes.

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful code, really nice work Thanks!

@gusinacio gusinacio merged commit bab22af into main Nov 7, 2024
10 checks passed
@gusinacio gusinacio deleted the shiyasmohd/create-subgraph-health-endpoint branch November 7, 2024 19:58
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants