Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

feat(chain): Arweave integration #262

Merged
merged 13 commits into from
May 16, 2022
Merged

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Apr 13, 2022

Copy link
Contributor

@maoueh maoueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, main stuff that is missing is the TypeId changes.

Each type defined in here need to be listed in the TypeId and id_of_type needs to be updated.

The value of the different IDs must be in a specific range, we decided that each chain would have a range of the ids allocated to it, for example Arweave could have the range 2000 - 3000. See graphprotocol/graph-node#3446.

@clearloop clearloop marked this pull request as ready for review April 26, 2022 10:07
@clearloop clearloop requested a review from maoueh April 28, 2022 16:07
@evaporei evaporei self-assigned this May 3, 2022
@evaporei
Copy link
Contributor

evaporei commented May 5, 2022

@clearloop you can apply the TypeId changes that you've made in graph-node so we can approve/merge it 🙂

@clearloop clearloop requested a review from evaporei May 5, 2022 23:08
@evaporei
Copy link
Contributor

@clearloop sorry for taking a bit to review this

but I think the CI is failing because you should copy the new files in the test.js script: https://github.com/graphprotocol/graph-ts/blob/main/test/test.js#L6

I you can try running npm test locally please 🙂

global/global.ts Outdated Show resolved Hide resolved
@clearloop
Copy link
Contributor Author

@clearloop sorry for taking a bit to review this

but I think the CI is failing because you should copy the new files in the test.js script: https://github.com/graphprotocol/graph-ts/blob/main/test/test.js#L6

I you can try running npm test locally please 🙂

$ yarn run v1.22.17
warning package.json: License should be a valid SPDX license expression
$ node test/test.js
Compiling test file test/bigInt.ts to WASM...
Compiling test file test/bytes.ts to WASM...
Compiling test file test/entity.ts to WASM...
Running "test/bigInt.ts" tests...
Running "testBigInt"...
Running "test/bytes.ts" tests...
Running "testBytesWithByteArray"...
Running "testBytesFromUTF8"...
Running "test/entity.ts" tests...
Running "testEntity"...
Done in 1.03s.

npm test works on my machine, but npm build doesn't

$ yarn build
warning package.json: License should be a valid SPDX license expression
$ asc --explicitStart --exportRuntime --runtime stub index.ts helper-functions.ts --lib graph-ts -b index.wasm
asc: unrecognized option '--explicitStart'
Advanced Strategic Command: a turn based strategy game 
usage: asc [ -xylcrwfqhv ] 
  [ -x ] [ --xresolution ]  (type=INTEGER, range=800..., default=1024)
         Set horizontal resolution to <X>
  [ -y ] [ --yresolution ]  (type=INTEGER, range=600..., default=800)
         Set vertical resolution to <Y>
  [ -l ] [ --load ]  (type=STRING)
         Load a map, save game, or email game on startup
  [ -c ] [ --configfile ]  (type=STRING)
         Use given configuration file
  [ -r ] [ --verbose ]  (type=INTEGER, range=0...10, default=0)
         Set verbosity level to x (0..10)
  [ -w ] [ --window ]  (type=FLAG)
         Disable fullscreen mode
  [ -f ] [ --fullscreen ]  (type=FLAG)
         Enable fullscreen mode (overriding config file)
  [ -q ] [ --nosound ]  (type=FLAG)
         Disable sound
  [ -h ] [ --help ]  (type=FLAG)
         Display help information.
  [ -v ] [ --version ]  (type=FLAG)
         Output version.
Done in 0.04s.

chain/arweave.ts Outdated Show resolved Hide resolved
@clearloop clearloop requested a review from evaporei May 13, 2022 08:46
@evaporei evaporei merged commit a924a1f into graphprotocol:main May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants