Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow updating metadata #1714

Merged
merged 2 commits into from
Aug 8, 2024
Merged

feat: allow updating metadata #1714

merged 2 commits into from
Aug 8, 2024

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Aug 6, 2024

CleanShot.2024-08-06.at.15.38.36.mp4

closes #1708

Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: 6f4de8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Aug 6, 2024

Deploying graph-tooling with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f4de8a
Status: ✅  Deploy successful!
Preview URL: https://def2475c.graph-tooling.pages.dev
Branch Preview URL: https://saihaj-i1707.graph-tooling.pages.dev

View logs

@YaroShkvorets
Copy link
Collaborator

Seems to work. As far as I understand the logic is

  • if the version hasn't been published yet we execute publishNewVersion()
  • if it's an existing version we execute updateMetadata()

A couple of things:

  • Not very obvious that you need to connect the wallet. Maybe the disabled "Deploy" button should say "Connect Wallet First" if the wallet is not connected.
  • In Metamask I have "Arbitrum Sepolia" active, in the form combo box I have "Testnet" selected. I click on "Connect Wallet" button and Metamask wants to switch to "Arbitrum One" for some reason.

@saihaj
Copy link
Member Author

saihaj commented Aug 8, 2024

Not very obvious that you need to connect the wallet. Maybe the disabled "Deploy" button should say "Connect Wallet First" if the wallet is not connected.

updated this here 6f4de8a

In Metamask I have "Arbitrum Sepolia" active, in the form combo box I have "Testnet" selected. I click on "Connect Wallet" button and Metamask wants to switch to "Arbitrum One" for some reason.

something related to MM extension 🤔 if it becomes too big of an issue can ticket and investigate later

@saihaj saihaj merged commit d0cb82a into main Aug 8, 2024
8 of 11 checks passed
@saihaj saihaj deleted the saihaj/i1707 branch August 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph publish should update subgraph metadata if changed
2 participants