make timestamp numeric #3902
Merged
make timestamp numeric #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
filipe/fix-timestamp-format
branch
from
07a292d to
2c27873
Compare
mangas
force-pushed
the
filipe/fix-timestamp-format
branch
from
2c27873 to
08a743b
Compare
lutter
approved these changes
Sep 6, 2022
store/postgres/src/chain_store.rs
Outdated
|
|
||
| let radix = if ts.starts_with("0x") { 16 } else { 10 }; | ||
|
|
||
| u64::from_str_radix(&ts[2..], radix) |
There was a problem hiding this comment.
This isn't right when the string is base 10 - there we don't want to skip the first two chars
| "Timestamp of the block if available, format depends on the chain" | ||
| timestamp: String | ||
| "Timestamp of the block if available" | ||
| timestamp: Int |
There was a problem hiding this comment.
The comment should also say something about how to interpret that number - maybe add Integer representation of the timestamp stored in blocks for the chain to tell people that we don't do any other processing
mangas
force-pushed
the
filipe/fix-timestamp-format
branch
2 times, most recently
from
6ee6a71 to
beaaf61
Compare
mangas
force-pushed
the
filipe/fix-timestamp-format
branch
from
beaaf61 to
ea7fb2b
Compare
mangas
commented
Sep 7, 2022
kaiwetlesen
pushed a commit
to kaiwetlesen/graph-node
that referenced
this pull request
Sep 7, 2022
* make timestamp numeric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.