Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put receipts into Arcs to prevent excessive cloning. #3443

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Put receipts into Arcs to prevent excessive cloning. #3443

merged 2 commits into from
Apr 8, 2022

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Apr 7, 2022

This PR aims to improve performance issues introduced in #3373.

It envelops TransactionReceipts in Arcss to share them without cloning inside the parse_log_triggers function.

tilacog added 2 commits April 7, 2022 14:50
@tilacog
chain, graph: Pass TransactionReceipts around inside Arcs
be507bd
@tilacog
chain/ethereum: Return Arc<TransactionReceipt> from more functions
21ed984 
This commit preventively puts `TransactionReceipt` into `Arc`s to
avoid an unecessary vector allocation.
@tilacog tilacog requested a review from leoyvens April 7, 2022 18:15
@tilacog
Copy link
Contributor Author

tilacog commented Apr 7, 2022 •
edited
Loading

The second commit in this PR preventively eliminates a redundant vector allocation introduced in the first commit, but it requires moreArcs than it might be necessary.

We can ignore/revert the second commit if we want fewer Arcs around or don't care about the extra vector allocation.

@tilacog tilacog merged commit 4464b04 into master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoyvens leoyvens leoyvens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilacog @leoyvens