-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce thread contention in subgraph indexing #937
Comments
Plan as outlined in #856 (comment):
|
I could still observe a small amount of contention and waiting after this, but it's reduced a lot from before. Part of #937.
I could still observe a small amount of contention and waiting after this, but it's reduced a lot from before. Part of #937.
Since increasing the size I still see 1ms and 10ms contention warnings, but no 100ms which is an improvement, contention seems to have shifted to the DB connection pool which was expected. Still the situation in tokio is not great, probably due to the issue described in tokio-rs/tokio#426 (comment). |
What's the latest here? Didn't we add the blocking threadpool recently? |
I believe we've sufficiently mitigated this issue that it shouldn't have any practical effect, but the solution is not ideal, so I'd like to keep this open. My explanation for the thread pool contention warnings that can still be observed sometimes is that half of them are due do this crossbeam bug (fix isn't released yet) and the other half is simply that there is contention for the CPUs, I haven't confirmed this yet, but it would be an ops concern, so I'm removing the label from this issue. |
No description provided.
The text was updated successfully, but these errors were encountered: