Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: nested sorting #307

Merged
merged 3 commits into from
Mar 14, 2023
Merged

docs: nested sorting #307

merged 3 commits into from
Mar 14, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Mar 9, 2023

@saihaj saihaj requested a review from a team as a code owner March 9, 2023 18:25
@saihaj saihaj force-pushed the saihaj/nested-sorting branch from 90e3665 to 86605a1 Compare March 9, 2023 19:16
azf20
azf20 suggested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Requesting a couple more clarifications and I think will be good to go.

website/pages/en/querying/graphql-api.mdx Show resolved Hide resolved
website/pages/en/querying/graphql-api.mdx Outdated Show resolved Hide resolved
@saihaj saihaj requested a review from azf20 March 9, 2023 20:51
azf20
azf20 suggested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question on the last sentence

website/pages/en/querying/graphql-api.mdx Outdated Show resolved Hide resolved
@saihaj saihaj requested a review from azf20 March 9, 2023 21:10
@saihaj saihaj merged commit 28c9f1f into main Mar 14, 2023
@saihaj saihaj deleted the saihaj/nested-sorting branch March 14, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azf20 azf20 azf20 approved these changes

@dotansimha dotansimha dotansimha approved these changes

@michaelanegus michaelanegus Awaiting requested review from michaelanegus

@MichaelMacaulay MichaelMacaulay Awaiting requested review from MichaelMacaulay

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

@schmidsi schmidsi Awaiting requested review from schmidsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saihaj @dotansimha @azf20