Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphPayments changes post audit #1078

Open
wants to merge 8 commits into
base: horizon
Choose a base branch
from
Open

GraphPayments changes post audit #1078

wants to merge 8 commits into from

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Dec 11, 2024

No description provided.

@tmigone tmigone changed the title feat: extract cancel thaw escrow to its own function GraphPayments changes post audit Dec 11, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Dec 11, 2024 •
edited
Loading

GraphPayments changes post audit

Generated at commit: 443b1ef72c19f172e04cf93b19469d98fcfb219e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone marked this pull request as draft December 17, 2024 19:52
@tmigone tmigone force-pushed the tmigone/post-trust-changes-payments branch from d3318eb to f056410 Compare December 18, 2024 16:59
@tmigone tmigone changed the base branch from tmigone/trust-fixes-payments to horizon December 18, 2024 17:00
@tmigone tmigone marked this pull request as ready for review January 27, 2025 18:13
@tmigone tmigone requested a review from Maikol January 27, 2025 18:13
@tmigone tmigone force-pushed the tmigone/post-trust-changes-payments branch from 36d203f to c907fd6 Compare February 6, 2025 17:37
@tmigone
feat: extract cancel thaw escrow to its own function
e1184d3 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
feat: add collector address to the RAV
c07ebda 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: change indexed event in RAVCollected event
9e22be6 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
test: improve coverage for GraphPayments
cb115ad 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: some minor improvements to GraphPayments and tests
0a99667 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
fix: couple minor improvments to PaymentsEscrow and some new tests
bcc2544 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: revert adding collector address to RAV
a3c95de 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: revert adding collector address to RAV in SubgraphService
443b1ef 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone tmigone force-pushed the tmigone/post-trust-changes-payments branch from 9a1a773 to 443b1ef Compare February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maikol Maikol Awaiting requested review from Maikol

Assignees
No one assigned
Labels
horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmigone