Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to graphp organization #130

Closed
clue opened this issue Mar 8, 2015 · 12 comments · Fixed by #163
Closed

Move to graphp organization #130

clue opened this issue Mar 8, 2015 · 12 comments · Fixed by #163

Comments

@clue
Copy link
Member

clue commented Mar 8, 2015

Now that all components have been split off into separate packages under the graphp organization, we should eventually also move this repository.

Things to consider:

  • Does this involve any BC breaks? What about consumers of this package?
  • Should we rename this package to the "graphp" vendor?
  • If so, what package name should we assign?

I'd like to migrate previous issues, PR, among with all watchers and stargazers, so forking does not seem to be an option.

Any input would be much appreciated!

@clemens-tolboom
Copy link
Collaborator

I recently moved a repo then cloned it back on the old location then removed all files except for the README.md to tell about the move.

Old consumers will still find the releases on the old location.

Do not forget to tell https://packagist.org

@clue
Copy link
Member Author

clue commented Jun 29, 2015

Thanks for the feedback!

Moving this repository to the graphp organization should actually be a no-brainer, given that GitHub automatically sets up redirects and Composer does a reasonable good job at following redirects.

I'm voting for moving this repository instead of setting up a clone (in either direction) because this will set up a working redirect for all existing links (including issues/PRs etc.)

The future home will likely be graphp/graph, though I'm not entirely sure I like the name (could be confusing?). Perhaps an additional redirect from graphp/graphp to graphp/graph (notice the subtle trailing p) could help? Also keep in mind the name is not set in stone…

Any input is welcome!

FWIW, renaming the package will be the next step that will probably be postponed for a few weeks (just in case).

@clue
Copy link
Member Author

clue commented Jul 4, 2015

Ping @ALL:

What do you think about the name "graphp/graph"?

Any better suggestions?

@clue
Copy link
Member Author

clue commented Oct 12, 2015

Ping @ALL:
What do you think about the name "graphp/graph"?

:shipit: ?

@clemens-tolboom
Copy link
Collaborator

I like the organization name. And hopefully it would be a good starting point finding sponsors.

@clue
Copy link
Member Author

clue commented Oct 12, 2015

For the reference, this ticket is only about moving this repo to the graphp organization, without affecting the composer package name. As such, this should not have a huge impact on our existing user base.

Updating the package name will be postponed to #134, as this will break compatibility with all existing users.

I like the organization name.

So do I :-) However, I'm not sure about the project name within this organization:

graphp/graph ?
graphp/graphp ?

This also affects the PHP namespace and class names:

Graphp\Graph\Graph ?
Graphp\Graph\Vertex

And hopefully it would be a good starting point finding sponsors.

Not sure I follow… what do you have in mind? :-)

@clemens-tolboom
Copy link
Collaborator

Ic � what about graphp/core ?

@clue
Copy link
Member Author

clue commented Oct 12, 2015

I like your suggestion, but then again, what is a "core"? :-)

https://en.wikipedia.org/wiki/Core_%28graph_theory%29

@clemens-tolboom
Copy link
Collaborator

core is core of graphp/* � guess kernel / base as similar disputable :p

@EmanueleMinotto
Copy link

Does this involve any BC breaks? What about consumers of this package?

To prevent any BC, I would move everything from PSR-4 to PSR-0 (e.g. src/Exception.php to src/Fhaculty/Graph/Exception.php), move old sources under the new namespace, make them extend the old classes (empty classes used temporary only to maintain the original type) and use a deprecations system to allow users to adapt their sources.

Example:

// src/Fhaculty/Graph/Graph.php

/**
 * @deprecated Deprecated since version 0.9, to be removed in 1.0. Use Graphp\Graph\Graph instead.
 */
class Graph
{
}

// src/Graphp/Graph/Graph.php

class Graph extends \Fhaculty\Graph\Graph
{
  // ...
}

Of course this change should be done in composer.json too, but that's considered an internal change, no APIs are involved.
The code shouldn't stay dirty for a long time considering that this library is at v0.9.

Should we rename this package to the "graphp" vendor?
If so, what package name should we assign?

Yes, I'm +1 for graphp/graph

Also the repository redirect is no more a pain.
If you need a help I'm available, https://github.com/graphp seems a really nice project. :)

@clue
Copy link
Member Author

clue commented Aug 26, 2016

Does this involve any BC breaks? What about consumers of this package?

Thanks for your valuable input @EmanueleMinotto, but I believe most of this actually belongs to #134 👍

This ticket here is only concerned with moving the repository to the https://github.com/graphp GitHub organization. As far as I can tell, this does not involve any BC breaks whatsoever, now that GitHub will setup redirects for HTTP and git links and composer seems to be able to cope with this just as well.

Should we rename this package to the "graphp" vendor?
Yes, I'm +1 for graphp/graph

Thanks! I think we agree here, so let's move forward on this one 👍

@clemens-tolboom
Copy link
Collaborator

I found https://github.com/graphp/graph which confuses me. It is a clone of this repo https://github.com/clue/graph which contradicts #130 (comment)

Moving this repository to the graphp organization should actually be a no-brainer, given that GitHub automatically sets up redirects and Composer does a reasonable good job at following redirects.

See also https://github.com/graphp/graph/network. I'm confused.

Regarding the name I'm still fine with graphp/graph :)

@clue clue closed this as completed in #163 Sep 29, 2018
@clue clue added this to the v0.10.0 milestone Sep 29, 2018
@clue clue modified the milestones: v0.10.0, v0.9.1 Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants