-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to graphp organization #130
Comments
I recently moved a repo then cloned it back on the old location then removed all files except for the README.md to tell about the move. Old consumers will still find the releases on the old location. Do not forget to tell https://packagist.org |
Thanks for the feedback! Moving this repository to the graphp organization should actually be a no-brainer, given that GitHub automatically sets up redirects and Composer does a reasonable good job at following redirects. I'm voting for moving this repository instead of setting up a clone (in either direction) because this will set up a working redirect for all existing links (including issues/PRs etc.) The future home will likely be graphp/graph, though I'm not entirely sure I like the name (could be confusing?). Perhaps an additional redirect from graphp/graphp to graphp/graph (notice the subtle trailing p) could help? Also keep in mind the name is not set in stone… Any input is welcome! FWIW, renaming the package will be the next step that will probably be postponed for a few weeks (just in case). |
Ping @ALL: What do you think about the name "graphp/graph"? Any better suggestions? |
|
I like the organization name. And hopefully it would be a good starting point finding sponsors. |
For the reference, this ticket is only about moving this repo to the graphp organization, without affecting the composer package name. As such, this should not have a huge impact on our existing user base. Updating the package name will be postponed to #134, as this will break compatibility with all existing users.
So do I :-) However, I'm not sure about the project name within this organization: graphp/graph ? This also affects the PHP namespace and class names:
Not sure I follow… what do you have in mind? :-) |
Ic � what about graphp/core ? |
I like your suggestion, but then again, what is a "core"? :-) |
core is core of graphp/* � guess kernel / base as similar disputable :p |
To prevent any BC, I would move everything from PSR-4 to PSR-0 (e.g. src/Exception.php to src/Fhaculty/Graph/Exception.php), move old sources under the new namespace, make them extend the old classes (empty classes used temporary only to maintain the original type) and use a deprecations system to allow users to adapt their sources. Example: // src/Fhaculty/Graph/Graph.php
/**
* @deprecated Deprecated since version 0.9, to be removed in 1.0. Use Graphp\Graph\Graph instead.
*/
class Graph
{
}
// src/Graphp/Graph/Graph.php
class Graph extends \Fhaculty\Graph\Graph
{
// ...
} Of course this change should be done in composer.json too, but that's considered an internal change, no APIs are involved.
Yes, I'm +1 for graphp/graph Also the repository redirect is no more a pain. |
Thanks for your valuable input @EmanueleMinotto, but I believe most of this actually belongs to #134 👍 This ticket here is only concerned with moving the repository to the https://github.com/graphp GitHub organization. As far as I can tell, this does not involve any BC breaks whatsoever, now that GitHub will setup redirects for HTTP and git links and composer seems to be able to cope with this just as well.
Thanks! I think we agree here, so let's move forward on this one 👍 |
I found https://github.com/graphp/graph which confuses me. It is a clone of this repo https://github.com/clue/graph which contradicts #130 (comment)
See also https://github.com/graphp/graph/network. I'm confused. Regarding the name I'm still fine with graphp/graph :) |
Now that all components have been split off into separate packages under the graphp organization, we should eventually also move this repository.
Things to consider:
I'd like to migrate previous issues, PR, among with all watchers and stargazers, so forking does not seem to be an option.
Any input would be much appreciated!
The text was updated successfully, but these errors were encountered: