added a link to the header back to itself #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +60,7 @@ | |||
| </head> | |||
| <body> | |||
| <div class="header"> | |||
| <span class="title">Graphite</span> | |||
| <span class="title"><a href="/" STYLE="TEXT-DECORATION: NONE"><font color=white>Graphite</font></a></span> | |||
| <div class="nav"> | |||
There was a problem hiding this comment.
Let's avoid inline styles going forward. Please remove the STYLE from here and add it to the HEAD styles instead (hint: insert at L38).
.header .title a {
text-decoration: none;
color: #fff;
}
fessyfoo
pushed a commit
to opentable/graphite-web
that referenced
this pull request
Nov 13, 2014
0.9.x nodaemon backport (rebase of graphite-project#144 to 0.9.x branch)
|
@linkslice It's not a bad idea at all, but unfortunately we already moved away from the text header to a background image with the new logo. If you can come up with a good way to link the logo (e.g. http://stackoverflow.com/a/25422362/2275058) I'd be happy to merge it in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeah, it might be dumb. But I've gotten used to clicking on the 'logo' in the top left of pages to return to the home. It's a quick n easy way to clear a composer window that you don't want anymore.