Fix legendHeight when rendering secondYAxis (master) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleinart
added a commit
that referenced
this pull request
Apr 3, 2013
Fix legendHeight when rendering secondYAxis (master)
|
Alright, now that I've got a bit more context, this may be helpful: The graph that shows this symptom has 2 metrics on each y-axis, and their aliases are around 12 characters each. It only manifests itself when the graph is enlarged (or maximised). |
|
I think this is applicable: |
fessyfoo
pushed a commit
to opentable/graphite-web
that referenced
this pull request
Nov 13, 2014
…sent metric with too big name" to 0.9.x Fixes graphite-project#267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to divide
numberOfLinesbycolumnswhen calculating ourlineHeightfor graphs usingsecondYAxis.Before:
After:
See #253 for discussion.