Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Ceres storage backend against TimeSeriesDatabase #596

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Implement the Ceres storage backend against TimeSeriesDatabase #596

merged 1 commit into from
Sep 21, 2016

Conversation

iain-buclaw-sociomantic
Copy link
Contributor

With the other TimeSeriesDatabase changes now in. Adding ceres (or any other backend) support into carbon is relatively straightforward.

This patch implements Ceres support.

@obfuscurity
Copy link
Member

LGTM

@iain-buclaw-sociomantic
Copy link
Contributor Author

iain-buclaw-sociomantic commented Sep 21, 2016

I should also say that what's missing are ceres maintenance files, some of which are found in the megacarbon branch here:

https://github.com/graphite-project/carbon/tree/megacarbon/plugins/maintenance

@obfuscurity
Copy link
Member

@iain-buclaw-sociomantic Planning a separate PR for those?

@iain-buclaw-sociomantic
Copy link
Contributor Author

Can do if you think it's best to have it in carbon, maybe under some third party directory? I don't know how integrated you'd like ceres to be. :-)

In any case, after the maintenance files, I guess that's the megacarbon branch finished.

@obfuscurity
Copy link
Member

Nah, I'd assume we want that to remain in the Ceres project, but in master.

@iain-buclaw-sociomantic
Copy link
Contributor Author

OK, so I'll check that there are no dependencies on carbon (these are standalone maintenance plugins) and raise the patch against graphite-project/ceres.

@obfuscurity obfuscurity merged commit 0b0e701 into graphite-project:master Sep 21, 2016
@iain-buclaw-sociomantic
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants