Fix infinite loop when back button is pressed #125
Conversation
…are closely related anyway
Janekdererste
changed the title
* Change jest config to use jsdom, so that window is available during testing * Add Window module to make it possible to mock the window object during testing
|
There are lots of whitespace changes in package-lock.json. When I auto-format the file in IntelliJ most changes go away. Should we apply the formatting? And maybe we should update package-lock.json in master first (unrelated to this issue). |
Try using @ notation for unti tests so that location of paths doesn't matter
|
Hm, I added .json files to my prettier config in intellij. I didn't think about the package.lock file. Do you think I shoulld revert this? |
Ah ok so we have to prettier package.lock after creating it. This sounds good to me. |
|
For some reason |
|
Ah |
|
Alright, I took the package-lock.json from master to avoid all the unecessary formatting diff. I think we shold let the lock file be ignored by prettier. This way we can stick with the formatting of the genrated file. |
|
Ok thanks. But don't we have to update the package-lock file in master? I thought the build did not pass with the current one?! |
|
The build on master was passing. My freshly installed computer generated a new lock file when installing dependencies. I hope that this works like this now. |
|
Thanks a lot @Janekdererste ! |
* Move parsing and creation of URL into NavBar component. Those things are closely related anyway * Create unit testing for NavBar. * Change jest config to use jsdom, so that window is available during testing * Add Window module to make it possible to mock the window object during testing * Remove old test and remove parameter from navbar on creation * trigger build * Re-install stuff on local machine to trigger new lock file? * Revert package-lock * Include test folder in tsconfig Try using @ notation for unti tests so that location of paths doesn't matter * use package-lock.json from master, so that the formatting is not applied Co-authored-by: Janekdererste <pewee-rescuer-delicacy-mum-pariah-thespian-weird-buzzy-dolby-tremor-shallow-spent-jag-geo-del> Co-authored-by: easbar <[email protected]> Co-authored-by: Peter <[email protected]>
fixes #116
This needs fixing of unit tests before it can be merged.