Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced feedback 2.0 #203

Closed
Willem3141 opened this issue Jun 1, 2021 · 0 comments
Closed

Advanced feedback 2.0 #203

Willem3141 opened this issue Jun 1, 2021 · 0 comments

Comments

@Willem3141
Copy link
Contributor

Willem3141 commented Jun 1, 2021

We need a refinement of the work done in #176 because many checks can return several distinct feedback strings. We need separate templates for all of them, like this:

            "feedback": {
                "passed": {
                    "template": "Correct!",
                    "description": "correct"
                },
                "too_many": {
                    "template": "Your answer had [[actual]] vertices; more than the [[expected]] expected",
                    "fields": ["actual", "expected"],
                    "description": "too many vertices"
                },
                "too_few": {
                    "template": "Your answer had [[actual]] vertices; few than the [[expected]] expected",
                    "fields": ["actual", "expected"],
                    "description": "too few vertices"
                }
            }

And then in the Python code for example:

        return {'correct': False,
                'feedback': 'too_few',
                'fields': { 'actual': ..... } }
Willem3141 added a commit that referenced this issue Jun 3, 2021
We want to push a version to the production server, but since advanced
feedback is not in its final form yet (see #203) this commit disables
advanced feedback for the only check that had it (undirected: vertex
count).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant