Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cart returns html instead of json #258

Closed
aristain opened this issue Apr 28, 2022 · 4 comments · Fixed by #272
Closed

Clear cart returns html instead of json #258

aristain opened this issue Apr 28, 2022 · 4 comments · Fixed by #272
Labels
bug Something isn't working

Comments

@aristain
Copy link

aristain commented Apr 28, 2022

Endpoint /cart/clear returns html insted of json when you make an web api call

@KrzysztofPajak KrzysztofPajak added the enhancement New feature or request label Apr 28, 2022
@magnuskarlssonhm
Copy link

I get an entire webpage when GET https://localhost:44350/cart as well.

@magnuskarlssonhm
Copy link

@KrzysztofPajak Out of curiosity, how come fetching a cart and getting a full webpage from an ecom API is not a bug but an enhancement? When would it ever be the expected bahaviour to get a webpage from an API?

@KrzysztofPajak
Copy link
Member

@magnuskarlssonhm I think you have right, it should be a bug.

@KrzysztofPajak KrzysztofPajak added bug Something isn't working and removed enhancement New feature or request labels May 16, 2022
@LeeDalchow
Copy link

Is this ok for me to pick this one up as a first contribution? Already taken a look in the code and found the areas this resides.

Is there a spec for the format of the JSON that is expected? I had a look on this page but it does not detail how the JSON should be formatted & the variable names - https://docs.grandnode.com/operations-on-shopping-cart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants