Update serialize operations for Gramps 6.0 #617
Conversation
|
In reference to #616 |
| @@ -39,13 +39,14 @@ def get(self, task_id: str): | |||
|
|
|||
| def serialize_or_str(obj): | |||
| try: | |||
| return json.dumps(obj) | |||
| return object_to_string(obj) # json.dumps(obj) | |||
There was a problem hiding this comment.
This module is quite sloppy because it doesn't use any type hints - in this function, obj is not a Gramps object, so there is no need to change it, we can leave json.dumps.
There was a problem hiding this comment.
| return object_to_string(obj) # json.dumps(obj) | |
| return json.dumps(obj) |
There was a problem hiding this comment.
All of the json methods have been replaced with optimized versions. If obj is actually a dict, then you should use dict_to_string (which uses orjson in this case, and is much faster). But anyway, we want to hide the details in these methods as they are all optimized and will always be the best methods of conversion, even if the internal representation changes going forward.
|
There seems to still be a |
|
Found the cause and will submit a PR to Gramps core soon. |
|
Fixed in gramps-project/gramps#1930 |
| from http import HTTPStatus | ||
|
|
||
| from celery.result import AsyncResult | ||
| from flask import abort | ||
|
|
||
| from . import ProtectedResource | ||
|
|
||
| from gramps.gen.lib.json_utils import object_to_string |
There was a problem hiding this comment.
| from gramps.gen.lib.json_utils import object_to_string |
There was a problem hiding this comment.
Probably want to change that to dict_to_string
| @@ -16,7 +16,8 @@ classifiers = [ | |||
| ] | |||
| requires-python = ">=3.9" | |||
| dependencies = [ | |||
| "gramps[GUI,i18n]==5.2.*", | |||
| "gramps[GUI,i18n]==6.0.0b1", | |||
There was a problem hiding this comment.
We can try with "gramps[all] @ git+https://github.com/gramps-project/gramps.git@maintenance/gramps60" now that the fixes have been merged into this branch.
WIP: this is a first draft of updating the serialization code to new Gramps 6.0 data representation.
I don't understand all of the code changed here, and I don't know what kinds of exceptions were caught (and why) and probably the new json_utils will raise different exceptions.