-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around TOML Python parser bug of parsing \x
#101
Conversation
The currently used TOML parser in Python is buggy and doesn't allow to parse filenames like `system-systemd\x2dcryptsetup.slice`. Since the only files that we detected in real world are systemd helper files (which are not used by graminized apps anyway), the current workaround is to simply skip such files when collecting `sgx.trusted_files`. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
7777f21
to
af6d2f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
a discussion (no related file):
Please create an issue about migration to tomli
in the main repo (and maybe also here? or just mention gsc in the main repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @mkow)
a discussion (no related file):
Previously, mkow (Michał Kowalczyk) wrote…
Please create an issue about migration to
tomli
in the main repo (and maybe also here? or just mention gsc in the main repo).
Done: gramineproject/gramine#968
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Description of the changes
The currently used TOML parser in Python is buggy and doesn't allow to parse filenames like
system-systemd\x2dcryptsetup.slice
. Since the only files that we detected in real world are systemd helper files (which are not used by graminized apps anyway), the current workaround is to simply skip such files when collectingsgx.trusted_files
.The bug was already reported by someone else: uiri/toml#404.
The bug was found in #100.
Fixes #100.
How to test this PR?
Try the workload in #100.
Looks like this:
This change is