[tools/RA-TLS] Copy quote from X.509 cert into a separate object

[dimakuv]

Description of the changes

Previously, extract_quote_and_verify_pubkey() returned a pointer to the SGX quote located inside the X.509 certificate. This is a confusing pattern, so this commit introduces a copy operation, to copy the SGX quote into a newly allocated object whose ownership is passed to the callers of this func.

How to test this PR?

CI is enough.

---

This change is 

[dimakuv]

Reviewable status: 0 of 5 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

a discussion (no related file):
FYI: extracted from #1039.

---

---

tools/sgx/ra-tls/ra_tls_common.h line 27 at r1 (raw file):

    { 0x06, 0x09, 0x2A, 0x86, 0x48, 0x86, 0xF8, 0x4D, 0x8A, 0x39, (N) }
static const uint8_t g_quote_oid[] = OID(0x06);
static const size_t g_quote_oid_size = sizeof(g_quote_oid);

FYI: This change is a bit unrelated, but I tucked it into this PR for simplicity.

Just like this whole PR, this change is also extracted from #1039.

[kailun-qin]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

[mkow]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakuv)

---

tools/sgx/ra-tls/ra_tls_verify_common.c line 243 at r1 (raw file):

    /* quote returned by find_oid_in_cert_extensions() is a pointer somewhere inside of the X.509
     * cert object; let's copy it into a newly allocated object to correctly track ownership */

(this is not required for correct ownership tracing, it just makes it more straightforward)

Suggestion:

let's copy it into a newly allocated object to make tracing ownership easier

[dimakuv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakuv)

---

tools/sgx/ra-tls/ra_tls_verify_common.c line 243 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

(this is not required for correct ownership tracing, it just makes it more straightforward)

Will do during rebase.

[dimakuv]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin and @mkow)

---

tools/sgx/ra-tls/ra_tls_verify_common.c line 243 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Will do during rebase.

Done.

[kailun-qin]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @mkow)

[mkow]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved